Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 remove mac electron app code-signing #2715

Merged
merged 9 commits into from
May 7, 2024
Merged

Conversation

MatissJanis
Copy link
Member

@MatissJanis MatissJanis commented May 6, 2024

Code signing was pre-requisite for publishing to mac app store. However, I never fully got the mac-apps-store version (it was crashing after publishing). So removing the code signing (for now).

Also applying a patch for #2705 (Electron app not working on mac):

  • upgraded vite/swc dependencies
  • removed PWA usage from electron apps (this is the root cause of the problem)

Copy link

netlify bot commented May 6, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 7397e6b
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6638ef7e7e2e4300099d31d1
😎 Deploy Preview https://deploy-preview-2715.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented May 6, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.7 MB → 4.7 MB (+584 B) +0.01%
Changeset
File Δ Size
�vite/preload-helper.js 📈 +585 B (+21.84%) 2.62 kB → 3.19 kB
package.json 📉 -1 B (-0.03%) 2.8 kB → 2.8 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 2.99 MB → 2.99 MB (+584 B) +0.02%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 59.7 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.41 kB 0%
static/js/wide.js 263.53 kB 0%
static/js/ReportRouter.js 1.22 MB 0%

Copy link
Contributor

github-actions bot commented May 6, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@MatissJanis MatissJanis marked this pull request as ready for review May 6, 2024 15:01
@MatissJanis MatissJanis linked an issue May 6, 2024 that may be closed by this pull request
2 tasks
@MatissJanis MatissJanis merged commit c16f4c7 into master May 7, 2024
19 checks passed
@MatissJanis MatissJanis deleted the matiss/remove-csc branch May 7, 2024 07:04
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Desktop app on macOS budget loading error
2 participants