-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Events: Add geolocated events to Events landing page #1160
Comments
Does converting IPs to regions and using them for caching work here? (to increase the cache hit rate) |
🤔 that's an interesting idea. We could maybe convert it to coordinates, and then round it off to Another thing we could try is what the Events Widget does, which is round off the last octet of the IP, so that it's just the class C address (e.g., Maybe it'd be best to fetch the events via a REST request, so that it doesn't block the TTFB. That way we don't have to worry as much about caching 🤔 |
@fcoveram, can you create a design for this? I'm guessing it'll be similar to the Events Widget in Core, so we'd want a |
@StevenDufresne had a good idea, that this might not need a Instead of the |
I like the idea. I can polish Steve's idea this week 👌 |
Thanks! |
Here is an idea I have been iterating The feature is inside the "Country" filter, now renamed as "Location", and it appears as a first option showing the location name and the radio area. Once clicking on it, the search results page shows the results filtered as now. I wonder how we can bring the location name as, afaik, it depends on the browser settings, and converting the distance unit for different metric systems (kilometers, miles, etc). |
That sounds good 👍🏻 I'd recommend leaving off the distance, because the Events API has different ranges for different event types. Folks are willing to go farther to attend a WordCamp than a meetup, so we use |
@StevenDufresne and I were talking more about the problem of not having enough events displayed, and came up with the idea of showing both local and global events at the same time. One way to do that would be to have a section for each, something like: |
Showing 10 events in the homepage was intentional to keep the page slightly short and give space for other sections. And since events are the main content, the "Browse events" button and the link in local nav reinforce the navigation to land on the "Upcoming events" page where currently there are many items. I disagree that the amount of events displayed is a problem. I also understand that we plan to include more types of events in the future, so "Upcoming events" would be even longer. I do like the idea of featuring global events, but it seems that fits better with the next phase of implementation, where more rich-content events are also included. What do you think of addressing this idea later? |
I was thinking we'd still keep it to 10 events or less, but they'd be spread across the two sections. I don't have a strong opinion about addressing that now vs in the next phase. What do you think @StevenDufresne ? |
@fcoveram Thinking about this iteration, I'm not certain that updating the country to be To elaborate on @iandunn's comment about our conversation, which wasn't specific to the details of your proposed design, is that we don't have many events for the rest of the world. Here is how the conversation went:
|
When we built the Events Widget in Core, we decided to use IP geolocation rather than the browser. That was in order to avoid having to interrupt the user w/ that prompt. I assumed that we'd use the same approach here, what do you think about that? |
Showing the visitor events near them would be more useful than a list of all events in the world. We could reuse a lot of the code in the Events Widget in Core, but it'd be faster to query the
wporg_events
table directly, rather than making an API request. Bypassing the API might mean forking a lot of that code, though, so we should test out which approach is better.We may need to add some extra caching around geolocation/results, since the number of visitors will be much higher than what the Events Widget is designed for. There won't be many cache hits based on IP address, since those will mostly be unique.
We need to work out the details of how it should function and look. We may want to include a way for the visitor to set their location, just like the Events Widget does.
The text was updated successfully, but these errors were encountered: