-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Events: Show nearby events on front page #1183
base: production
Are you sure you want to change the base?
Conversation
15162cf
to
ef3cbbc
Compare
8fe0dbe
to
d3d58c7
Compare
The functionality is working. Once the design is done I'll incorporate that. Here's a few problems I've run into that I haven't found good solutions for:
If anyone has any ideas for those I'd curious to hear them. @renintw @adamwoodnz @StevenDufresne |
What we do in Core is to use that as an opportunity to encourage folks to organize. I really like that because it lets folks know that we're an open community, and that they don't have to wait for someone else to do it. If there aren't any events in their area, I don't think sorting the events outside their area (which could be hours away in many cases) really solves the problem of making the results relevant. What do you think about that? Also cc @fcoveram in case we want to change the design. |
I shared an idea in the issue to keep design feedback and iteration over there. |
d891ccc
to
4405d4a
Compare
The design team wants to wait on this for a bit, and I'll be on leave the next few months. If anyone wants to pick this up while I'm gone, here's an overview: Functionality:
Implementing the design:
|
4405d4a
to
0c07255
Compare
Fixes #1160
This hides the current list of upcoming events by default, and adds a list of events that are geographically close to the user. There are buttons to toggle back and forth between the two views.
Those are fetched from api.w.org/events instead of directly querying
wporg_events
in order to take advantage of the geolocation logic that API has. The request is made via XHR in order to avoid a blocking HTTP request before the TTFB.I don't expect a large number of cache hits on the Events API, since the payload includes the visitors (anonymized) IP. I think the API will be able to absorb the additional traffic without any problem, though, because of the relatively small amount of traffic on events.w.org.
[ todo add screenshots ]