Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect tested up to comparison #779

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix incorrect tested up to comparison #779

wants to merge 1 commit into from

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Nov 8, 2024 •
edited
Loading

Fixes #778

Since we use similar logic to fetch latest WordPress version (using only X.Y) part, I think it would make sense for using similar for Tested up to.

@ernilambar ernilambar marked this pull request as ready for review November 8, 2024 11:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar requested a review from swissspidy November 8, 2024 11:14
@ernilambar ernilambar mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidperezgar davidperezgar davidperezgar approved these changes

@barrykooij barrykooij Awaiting requested review from barrykooij barrykooij is a code owner

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

@chriscct7 chriscct7 Awaiting requested review from chriscct7 chriscct7 is a code owner

@swissspidy swissspidy Awaiting requested review from swissspidy

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Tested up to comparison
2 participants
@ernilambar @davidperezgar