-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Tested up to comparison #778
Comments
FWIW |
Ideally, yes I agree. Non existent tested up to Error should be triggered for >=6.8 in above example. May be trimming down patch part in the version string given by Parser should solve the problem. WDYT? |
var_dump( version_compare( '6.7', '6.7', '>' ) ); // Output false.
var_dump( version_compare( '6.7.0', '6.7', '>' ) ); // Output true. |
Question is whether you want to throw a warning/error for |
In the directory, I believe third part is simply ignored. CC @dd32 Can you please confirm? Should trimming down third part would be good (and in sync with the directory)? |
I have this line in my plugin:
And still get this
Tested on WP 6.7 RC 4, running PCP 1.2.0 |
May be this will fix ? #779 |
@Zodiac1978 I checked with WP 6.7 RC4 and PCP 1.2( and also with trunk) but could not reproduce the error mentioned. Please create separate issue with steps to reproduce the issue. We will discuss the matter in new issue. |
@ernilambar I couldn't reproduce it with a fresh local install too, but it stays there (with the same setup) on my testserver. This makes me think why it happens and what causes this. Maybe some transient I need to delete? |
Current WP version: 6.6
In readme:
nonexistent_tested_upto_header
is triggered which is not correct. This error should be triggered for two major versions up.The text was updated successfully, but these errors were encountered: