Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Tested up to comparison #778

Open
ernilambar opened this issue Nov 8, 2024 · 9 comments · May be fixed by #779
Open

Incorrect Tested up to comparison #778

ernilambar opened this issue Nov 8, 2024 · 9 comments · May be fixed by #779
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Bug An existing feature is broken

Comments

@ernilambar
Copy link
Member

ernilambar commented Nov 8, 2024

Current WP version: 6.6

In readme:

Tested up to: 6.7.0

nonexistent_tested_upto_header is triggered which is not correct. This error should be triggered for two major versions up.

@ernilambar ernilambar added [Team] Plugin Review Issues owned by Plugin Review Team [Type] Bug An existing feature is broken labels Nov 8, 2024
@swissspidy
Copy link
Member

FWIW Tested up to: 6.7.0 is incorrect too, should be Tested up to: 6.7

@ernilambar
Copy link
Member Author

Ideally, yes I agree. Non existent tested up to Error should be triggered for >=6.8 in above example. May be trimming down patch part in the version string given by Parser should solve the problem. WDYT?

@ernilambar
Copy link
Member Author

var_dump( version_compare( '6.7', '6.7', '>' ) );  // Output false.
var_dump( version_compare( '6.7.0', '6.7', '>' ) ); // Output true.

@ernilambar ernilambar linked a pull request Nov 8, 2024 that will close this issue
@swissspidy
Copy link
Member

Question is whether you want to throw a warning/error for x.x.x or not.

@ernilambar
Copy link
Member Author

In the directory, I believe third part is simply ignored.

CC @dd32 Can you please confirm? Should trimming down third part would be good (and in sync with the directory)?

@Zodiac1978
Copy link

I have this line in my plugin:

Tested up to: 6.6

And still get this nonexistent_tested_upto_header error, saying:

Tested up to: 6.6.
The "Tested up to" value in your plugin is not valid. This version of WordPress does not exist (yet). 

Tested on WP 6.7 RC 4, running PCP 1.2.0

@ernilambar
Copy link
Member Author

May be this will fix ? #779
Would you be able to check it?

@ernilambar
Copy link
Member Author

ernilambar commented Nov 11, 2024

@Zodiac1978 I checked with WP 6.7 RC4 and PCP 1.2( and also with trunk) but could not reproduce the error mentioned. Please create separate issue with steps to reproduce the issue. We will discuss the matter in new issue.

@Zodiac1978
Copy link

@ernilambar I couldn't reproduce it with a fresh local install too, but it stays there (with the same setup) on my testserver. This makes me think why it happens and what causes this. Maybe some transient I need to delete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Bug An existing feature is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants