Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang-tidy to buildsystem checks #1157

Closed
wants to merge 7 commits into from
Closed

Add clang-tidy to buildsystem checks #1157

wants to merge 7 commits into from

Conversation

simonsan
Copy link
Contributor

@simonsan simonsan commented Sep 25, 2019 •
edited
Loading

Fixes #1060 continued from PR #1063

Regarding #49

Plan is:

  • Add a diagnose python-module that is making the checks after you call ./configure (compile-commands.json) and add several other code-checks (clazy, etc.).
  • Add a make target: make diagnose for all that checkups
  • Export a (todo) list with warnings and errors for better overview

@simonsan simonsan added area: buildsystem Related to our cmake/python buildsystem nice new thing ☺ A new feature that was not there before labels Sep 25, 2019
@simonsan simonsan force-pushed the clang-tidy branch 3 times, most recently from 2bb48e3 to e84091b Compare September 25, 2019 09:44
@simonsan simonsan mentioned this pull request Sep 26, 2019
Closed
@simonsan simonsan force-pushed the clang-tidy branch 3 times, most recently from c94ee89 to ec1a72a Compare October 13, 2019 19:24
@simonsan simonsan marked this pull request as draft April 24, 2020 07:08
@simonsan simonsan changed the title [WIP] Add clang-tidy to buildsystem checks Add clang-tidy to buildsystem checks Apr 24, 2020
@simonsan simonsan mentioned this pull request Apr 30, 2020
Closed
26 tasks
@simonsan simonsan force-pushed the clang-tidy branch 2 times, most recently from a82debd to efc390b Compare May 1, 2020 20:12
@simonsan simonsan mentioned this pull request May 2, 2020
Closed
13 tasks
@simonsan
Copy link
Contributor Author

(Outdated)

@simonsan simonsan closed this Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: buildsystem Related to our cmake/python buildsystem nice new thing ☺ A new feature that was not there before
Projects
openage code quality
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add clang-tidy to buildsystem checks
2 participants
@simonsan @kev946