Clang-tidy build working from CMakeLists.txt, turned off again

SFTtech · Sep 25, 2019 · e84091b · e84091b
1 parent a82975c
commit e84091b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -141,7 +141,6 @@ option(
 )
 
 if(ENABLE_CLANG_TIDY)
-	set(CMAKE_EXPORT_COMPILE_COMMANDS "ON")
 	set(CMAKE_CXX_CLANG_TIDY "clang-tidy;-checks=-checks=cppcoreguidelines-*,clang-analyzer-*,bugprone-*,performance-*,portability-*,misc-*,modernize-*,hicpp-*,cert-*,readability-*,llvm-twine-local,llvm-prefer-isa-or-dyn-cast-in-conditionals, llvm-prefer-register-over-unsigned, google-readability-casting -extra-arg=-std=c++17")
 endif()
 

diff --git a/buildsystem/codecompliance/__main__.py b/buildsystem/codecompliance/__main__.py
@@ -47,7 +47,6 @@ def parse_args():
                            "copyright year matches the git history."))
     cli.add_argument("--clangtidy", action="store_true",
                      help="check the cpp code with clang-tidy")
-
     cli.add_argument("--fix", action="store_true",
                      help=("try to automatically fix the found issues"))
 

diff --git a/buildsystem/codecompliance/clangtidy.py b/buildsystem/codecompliance/clangtidy.py
@@ -12,10 +12,10 @@
 
 def find_issues(check_files, dirnames):
     """ Invokes the external clang-tidy tool. """
-    invocation = ['clang-tidy', '-checks=cppcoreguidelines-*,clang-analyzer-*,bugprone-*, ' + 
-                  'performance-*,portability-*,misc-*,modernize-*,hicpp-*,cert-*, ' + 
-                  'llvm-twine-local,llvm-prefer-isa-or-dyn-cast-in-conditionals, ' + 
-                  'llvm-prefer-register-over-unsigned,google-readability-casting ' + 
+    invocation = ['clang-tidy', '-checks=cppcoreguidelines-*,clang-analyzer-*,bugprone-*, ' +
+                  'performance-*,portability-*,misc-*,modernize-*,hicpp-*,cert-*, ' +
+                  'llvm-twine-local,llvm-prefer-isa-or-dyn-cast-in-conditionals, ' +
+                  'llvm-prefer-register-over-unsigned,google-readability-casting ' +
                   '-extra-arg=-std=c++17']
 
     if check_files is not None:
-Original file line number
+Diff line change
@@ Expand Up / @@ -141,7 +141,6 @@ option( @@
     )
     if(ENABLE_CLANG_TIDY)
-    	set(CMAKE_EXPORT_COMPILE_COMMANDS "ON")
     	set(CMAKE_CXX_CLANG_TIDY "clang-tidy;-checks=-checks=cppcoreguidelines-*,clang-analyzer-*,bugprone-*,performance-*,portability-*,misc-*,modernize-*,hicpp-*,cert-*,readability-*,llvm-twine-local,llvm-prefer-isa-or-dyn-cast-in-conditionals, llvm-prefer-register-over-unsigned, google-readability-casting -extra-arg=-std=c++17")
     endif()
@@ Expand Down @@