-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish and improve fluid implementation #291
Open
ExE-Boss
wants to merge
6
commits into
master
Choose a base branch
from
fix/fluid
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
============================================
- Coverage 13.58% 13.46% -0.12%
- Complexity 732 736 +4
============================================
Files 409 412 +3
Lines 12788 12958 +170
Branches 1354 1375 +21
============================================
+ Hits 1737 1745 +8
- Misses 10934 11092 +158
- Partials 117 121 +4
Continue to review full report at Codecov.
|
ExE-Boss
added
the
in progress
Pull requests that are not yet ready to be merged and issues that are being worked on.
label
Mar 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
This is going to break stuff
feature
in progress
Pull requests that are not yet ready to be merged and issues that are being worked on.
rebase needed 🚧
This PR needs to resolve a merge conflict
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR near-fully implements Fluids.
Fluids are now registered in the following way:
To do list: