Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish and improve fluid implementation #291

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Finish and improve fluid implementation #291

wants to merge 6 commits into from

Conversation

ExE-Boss
Copy link
Member

@ExE-Boss ExE-Boss commented Mar 18, 2017

This PR near-fully implements Fluids.
Fluids are now registered in the following way:

FluidMod(GlobalEvents events, FluidManager fluidManager) {
    events.on(FluidManager.Init.class).bind(evt -> this.registerFluids(evt.manager));
}

void registerFluids(FluidManager fluidManager) {
    fluidManager.register(MOD_ID + ":custom_fluid", CustomFluid::new);
}

To do list:

  • Implement 1.7.10 and 1.8 fluid wrappers

@ExE-Boss ExE-Boss added breaking change This is going to break stuff feature labels Mar 18, 2017
@ExE-Boss ExE-Boss self-assigned this Mar 18, 2017
@ExE-Boss ExE-Boss requested a review from RX14 March 18, 2017 12:28
@codecov-io
Copy link

codecov-io commented Mar 18, 2017

Codecov Report

Merging #291 into master will decrease coverage by 0.11%.
The diff coverage is 10.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #291      +/-   ##
============================================
- Coverage     13.58%   13.46%   -0.12%     
- Complexity      732      736       +4     
============================================
  Files           409      412       +3     
  Lines         12788    12958     +170     
  Branches       1354     1375      +21     
============================================
+ Hits           1737     1745       +8     
- Misses        10934    11092     +158     
- Partials        117      121       +4
Impacted Files Coverage Δ Complexity Δ
...n/java/nova/core/component/fluid/FluidHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/nova/core/component/fluid/FluidFilter.java 0% <0%> (ø) 0 <0> (?)
src/main/java/nova/core/component/fluid/Tank.java 23.07% <0%> (-4.2%) 4 <0> (ø)
...e/wrapper/mc/forge/v18/launcher/NovaMinecraft.java 2.45% <0%> (-0.03%) 2 <0> (ø)
.../nova/core/component/fluid/FluidHandlerSimple.java 0% <0%> (ø) 0 <0> (?)
.../java/nova/core/component/fluid/FluidProvider.java 50% <0%> (-50%) 1 <0> (ø)
...e/wrapper/mc/forge/v17/launcher/NovaMinecraft.java 2.47% <0%> (-0.03%) 2 <0> (ø)
...nova/core/component/fluid/FluidHandlerWrapper.java 0% <0%> (ø) 0 <0> (?)
...n/java/nova/core/component/fluid/FluidFactory.java 35.71% <100%> (ø) 2 <0> (ø) ⬇️
...n/java/nova/core/component/fluid/FluidManager.java 85.71% <100%> (+15.71%) 4 <1> (+1) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8daac6...fb1e631. Read the comment docs.

@ExE-Boss ExE-Boss added the in progress Pull requests that are not yet ready to be merged and issues that are being worked on. label Mar 18, 2017
@ExE-Boss ExE-Boss mentioned this pull request Apr 21, 2017
17 tasks
@ExE-Boss ExE-Boss added the rebase needed 🚧 This PR needs to resolve a merge conflict label Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This is going to break stuff feature in progress Pull requests that are not yet ready to be merged and issues that are being worked on. rebase needed 🚧 This PR needs to resolve a merge conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants