Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minecraft 1.11.2 wrappers #234

Merged
merged 72 commits into from
Feb 21, 2019
Merged

Minecraft 1.11.2 wrappers #234

merged 72 commits into from
Feb 21, 2019

Conversation

ExE-Boss
Copy link
Member

@ExE-Boss ExE-Boss commented Jan 7, 2017

I’ve begun work on wrappers for Minecraft 1.11.

Depends on:

To do list:

Completed:


Moved from: #231
P.S.: I will do my best to not let NOVA die just yet, I just hope that life won’t get in the way of that.

@ExE-Boss ExE-Boss added the in progress Pull requests that are not yet ready to be merged and issues that are being worked on. label Jan 7, 2017
@ExE-Boss ExE-Boss self-assigned this Jan 7, 2017
@ExE-Boss ExE-Boss mentioned this pull request Jan 7, 2017
10 tasks
@ExE-Boss ExE-Boss added the minecraft 1.11 Affects Minecraft 1.11.x wrappers label Jan 7, 2017
@codecov-io
Copy link

codecov-io commented Jan 7, 2017

Codecov Report

Merging #234 into master will decrease coverage by 3.7%.
The diff coverage is 1.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #234      +/-   ##
============================================
- Coverage     16.97%   13.26%   -3.71%     
- Complexity      965     1005      +40     
============================================
  Files           416      532     +116     
  Lines         13176    17357    +4181     
  Branches       1382     1804     +422     
============================================
+ Hits           2236     2302      +66     
- Misses        10794    14908    +4114     
- Partials        146      147       +1
Impacted Files Coverage Δ Complexity Δ
...11_2/wrapper/render/forward/FWSmartBlockModel.java 0% <0%> (ø) 0 <0> (?)
..._11_2/wrapper/recipes/MinecraftRecipeRegistry.java 0% <0%> (ø) 0 <0> (?)
...e/v1_11_2/wrapper/block/forward/FWTileUpdater.java 0% <0%> (ø) 0 <0> (?)
...mc/forge/v1_11_2/wrapper/block/forward/FWTile.java 0% <0%> (ø) 0 <0> (?)
.../forge/v1_11_2/network/netty/MCNetworkManager.java 0% <0%> (ø) 0 <0> (?)
...11_2/wrapper/entity/forward/MCEntityTransform.java 0% <0%> (ø) 0 <0> (?)
...re/wrapper/mc/forge/v1_11_2/NovaMinecraftCore.java 0% <0%> (ø) 0 <0> (?)
...r/mc/forge/v1_11_2/wrapper/item/ItemConverter.java 0% <0%> (ø) 0 <0> (?)
...1_2/wrapper/recipes/forward/ShapedRecipeBasic.java 0% <0%> (ø) 0 <0> (?)
.../v1_11_2/wrapper/particle/backward/BWParticle.java 0% <0%> (ø) 0 <0> (?)
... and 686 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59455b7...78c87a1. Read the comment docs.

@RX14
Copy link
Contributor

RX14 commented Jan 7, 2017

Ignore coverage for this PR because it's a MC wrapper. I'll merge it regardless.

@calclavia
Copy link
Member

@RX14 Should we add @ExE-Boss as a contributor? He's made a decent amount of PRs

@RX14
Copy link
Contributor

RX14 commented Jan 7, 2017

@calclavia He is, I've made it so that all commits to the master branch need to be reviewed though.

@loordgek
Copy link

@ExE-Boss do you know that MC itemstack cannot be null??
do you know how the Capability stuff works?(it is realy cool)

@ExE-Boss
Copy link
Member Author

ExE-Boss commented Jan 10, 2017

@loordgek I am aware of both (I just forgot to push the non-null ItemStack fix for over a month).

@ExE-Boss ExE-Boss force-pushed the mc1.11 branch 2 times, most recently from 1adb7d6 to 6570b78 Compare January 17, 2017 14:32
@ExE-Boss ExE-Boss modified the milestones: v0.2.0, v0.1.0 Jan 18, 2017
@ExE-Boss ExE-Boss force-pushed the mc1.11 branch 4 times, most recently from 07ee783 to fe84ffe Compare February 1, 2017 18:23
@ExE-Boss ExE-Boss force-pushed the mc1.11 branch 2 times, most recently from 9a35c7c to ec5ae03 Compare February 27, 2017 14:59
@ExE-Boss ExE-Boss changed the title Minecraft 1.11 wrappers Minecraft 1.11.2 wrappers Feb 27, 2017
@ExE-Boss ExE-Boss force-pushed the mc1.11 branch 2 times, most recently from 017ca1b to 10c5374 Compare March 1, 2017 23:21
@ExE-Boss ExE-Boss force-pushed the mc1.11 branch 3 times, most recently from c8330cf to b07b399 Compare March 13, 2017 19:08
@ExE-Boss ExE-Boss removed rebase needed 🚧 This PR needs to resolve a merge conflict labels Feb 21, 2019
@ExE-Boss ExE-Boss merged commit 605895b into master Feb 21, 2019
@ExE-Boss ExE-Boss deleted the mc1.11 branch February 21, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Pull requests that are not yet ready to be merged and issues that are being worked on. minecraft 1.11 Affects Minecraft 1.11.x wrappers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants