-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minecraft 1.11.2 wrappers #234
Conversation
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
============================================
- Coverage 16.97% 13.26% -3.71%
- Complexity 965 1005 +40
============================================
Files 416 532 +116
Lines 13176 17357 +4181
Branches 1382 1804 +422
============================================
+ Hits 2236 2302 +66
- Misses 10794 14908 +4114
- Partials 146 147 +1
Continue to review full report at Codecov.
|
Ignore coverage for this PR because it's a MC wrapper. I'll merge it regardless. |
@calclavia He is, I've made it so that all commits to the master branch need to be reviewed though. |
@ExE-Boss do you know that MC itemstack cannot be null?? |
@loordgek I am aware of both (I just forgot to push the non-null |
1adb7d6
to
6570b78
Compare
07ee783
to
fe84ffe
Compare
9a35c7c
to
ec5ae03
Compare
017ca1b
to
10c5374
Compare
c8330cf
to
b07b399
Compare
I’ve begun work on wrappers for Minecraft 1.11.
Depends on:
Show NOVA logging messages in Minecraft logs #300(merged)Move the block's associated TileEntity on block move #290(merged)To do list:
FWSmartItemModel
'sItemCameraTransforms
BWModel.render
ICapabilityProvider
where appropriate. Thanks @shadowfacts for pointing that out at Implement IEnergyItem MinecraftForge/MinecraftForge#3599 (comment). (Depends on Implement Sided Components #261)FWCapabilityProvider
MCParticleTransform.rotation
(low priority, will probably be made obsolete by Separate particles from entities #281)Completed:
Squash all commitsBacked out because NOVA has moved to using merge commitsFWSmartModel.vertexToInts
TileEntityTransformer
Moved from: #231
P.S.: I will do my best to not let NOVA die just yet, I just hope that life won’t get in the way of that.