Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make used ForgeGradle version independently configurable #320

Merged
merged 1 commit into from
Jun 23, 2018

Conversation

ExE-Boss
Copy link
Member

This is required for both #234 and to migrate the Minecraft 1.8 wrappers to Minecraft Forge 11.14.4.1563 (the latest recommended Minecraft Forge build for Minecraft 1.8)

@ExE-Boss ExE-Boss self-assigned this Jun 23, 2018
@ExE-Boss ExE-Boss added minecraft 1.7 Affects Minecraft 1.7.x wrappers minecraft 1.8 Affects Minecraft 1.8.x wrappers minecraft 1.11 Affects Minecraft 1.11.x wrappers done Pull requests that are finished and are ready to be reviewed and merged labels Jun 23, 2018
@ExE-Boss ExE-Boss requested a review from RX14 June 23, 2018 02:33
@codecov-io
Copy link

codecov-io commented Jun 23, 2018

Codecov Report

Merging #320 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #320   +/-   ##
=========================================
  Coverage     16.99%   16.99%           
  Complexity      965      965           
=========================================
  Files           416      416           
  Lines         13165    13165           
  Branches       1383     1383           
=========================================
  Hits           2237     2237           
  Misses        10782    10782           
  Partials        146      146

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4522f32...e27ca96. Read the comment docs.

@ExE-Boss ExE-Boss merged commit e27ca96 into master Jun 23, 2018
ExE-Boss added a commit that referenced this pull request Jun 23, 2018
Make used ForgeGradle version independently configurable
@ExE-Boss ExE-Boss deleted the minecraft/build/forge-gradle branch June 23, 2018 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Pull requests that are finished and are ready to be reviewed and merged minecraft 1.7 Affects Minecraft 1.7.x wrappers minecraft 1.8 Affects Minecraft 1.8.x wrappers minecraft 1.11 Affects Minecraft 1.11.x wrappers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants