Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the build-mylib test into the regular test suite (and get rid of the separate build-mylib CI job) #991

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Oct 29, 2024

TODO:

  1. Go through and fix any TODOs.
  2. Uncomment all the commented-out lines in test/runtests.jl

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.17%. Comparing base (530b392) to head (8308cf8).

❗ There is a different number of reports uploaded between BASE (530b392) and HEAD (8308cf8). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (530b392) HEAD (8308cf8)
16 5
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
- Coverage   87.73%   80.17%   -7.56%     
==========================================
  Files           3        3              
  Lines         799      787      -12     
==========================================
- Hits          701      631      -70     
- Misses         98      156      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Base automatically changed from kc/stdlibs to master October 29, 2024 17:03
@DilumAluthge DilumAluthge force-pushed the dpa/build-mylib-separate-ci-job branch 4 times, most recently from 93ac8e8 to 3a64df6 Compare October 31, 2024 18:59
@DilumAluthge DilumAluthge force-pushed the dpa/build-mylib-separate-ci-job branch 3 times, most recently from 49ae767 to b3df37f Compare November 23, 2024 02:37
@DilumAluthge DilumAluthge force-pushed the dpa/build-mylib-separate-ci-job branch from b3df37f to f4bdaaf Compare November 24, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant