-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set JULIA_PROJECT
when running the subprocess in ensurecompiled()
#995
base: master
Are you sure you want to change the base?
Conversation
JULIA_PROJECT
when running the subprocess in `ensurecompiled()JULIA_PROJECT
when running the subprocess in ensurecompiled()
JULIA_PROJECT
when running the subprocess in ensurecompiled()
JULIA_PROJECT
when running the subprocess in ensurecompiled()
de20427
to
2ee4534
Compare
aa7ffc9
to
b38c01c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #995 +/- ##
==========================================
+ Coverage 87.73% 87.75% +0.01%
==========================================
Files 3 3
Lines 799 800 +1
==========================================
+ Hits 701 702 +1
Misses 98 98 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I would have think this is already the case from the existing code? Do you have something like an MWE where it isn't?
|
Good question. I haven't been able to come up with a MWE. I'm encountering some kind of problem (that I thought was |
b38c01c
to
1f98bca
Compare
1f98bca
to
6b59a30
Compare
Okay, so I do have an example where things don't seem to work unless I have this In #991, I'm working on moving the In that PR, if I don't have this
However, when I add this The only difference between the two commits (f4bdaaf and 8308cf8) is the |
Suppose that you have two different projects, where one project contains the packages that will go into the sysimage, and the other project is a "build project".
As an example, consider the
examples/MyLib
folder in this repo:examples/MyLib/Project.toml
is the "main project" that contains the packages that will go into the sysimage.examples/MyLib/build/Project.toml
is the "build project". The packages in the "build project" will not go into the sysimage. In this example, the "build project" containsLibdl
andPackageCompiler
, but neither of those will go into the sysimage.When the
ensurecompiled()
function is run, we want to make sure that it precompiles the "main project", not the "build project". That's what this PR does.