mysql: backwards compatibility fix for mysql
client binary
#201679
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
-DWITH_AUTHENTICATION_CLIENT_PLUGINS=yes
build arg to enable backwards compatibility for themysql
client that is included with the MySQL-9 formula. (Note that this fix does not cover the separatemysql-client
formula. If this change is accepted, I'm happy to patch themysql-client
formula, too.)This patches the accepted, upstream MySQL bug: https://bugs.mysql.com/bug.php?id=116616
The MySQL 9.0 Release notes state that the intent of the release was for the
mysql
client to remain backwards compatible by continuing to provide support for themysql_native_password
auth plugin. This is also reflected in the official MySQL binaries from Oracle, which were built with the-DWITH_AUTHENTICATION_CLIENT_PLUGINS=yes
. In the MySQL bug report linked above, the MySQL team has agreed that it was an error for the source build args to not include-DWITH_AUTHENTICATION_CLIENT_PLUGINS=yes
.Related to: #181805 (Original PR by @cswingler for the same fix for
mysql-client
)HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?