Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql: backwards compatibility fix for mysql client binary #201679

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Dec 18, 2024

Adds -DWITH_AUTHENTICATION_CLIENT_PLUGINS=yes build arg to enable backwards compatibility for the mysql client that is included with the MySQL-9 formula. (Note that this fix does not cover the separate mysql-client formula. If this change is accepted, I'm happy to patch the mysql-client formula, too.)

This patches the accepted, upstream MySQL bug: https://bugs.mysql.com/bug.php?id=116616

The MySQL 9.0 Release notes state that the intent of the release was for the mysql client to remain backwards compatible by continuing to provide support for the mysql_native_password auth plugin. This is also reflected in the official MySQL binaries from Oracle, which were built with the -DWITH_AUTHENTICATION_CLIENT_PLUGINS=yes. In the MySQL bug report linked above, the MySQL team has agreed that it was an error for the source build args to not include -DWITH_AUTHENTICATION_CLIENT_PLUGINS=yes.

Related to: #181805 (Original PR by @cswingler for the same fix for mysql-client)

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

…nable client backwards compatibility. Fixes accepted, upstream MySQL bug: https://bugs.mysql.com/bug.php?id=116616
@github-actions github-actions bot added the icu4c ICU use is a significant feature of the PR or issue label Dec 18, 2024
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a dependency on libfido

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icu4c ICU use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants