mysql-client: fix add authentication plugins in [email protected]

[cswingler]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

This addresses #180498 .

The MySQL 9.0 client is not built with support for older authentication methods by default, which breaks the ability for the MySQL client, and packages that depend on it, to connect to servers still using authentication methods like mysql_native_password. This adjusts the build process to add those back in as plugins.

A bug has been opened upstream to address the discrepancy between the documentation and the actual configuration: https://bugs.mysql.com/bug.php?id=116616

[SMillerDev]

Can you make an issue upstream requesting they enable this by default and add that as a comment? From the linked thread it seems like upstream thinks it's default already.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[zhangyangyu]

Can you make an issue upstream requesting they enable this by default and add that as a comment? From the linked thread it seems like upstream thinks it's default already.

@SMillerDev I downloaded the MySQL Community Server 9.0.1 Innovation on macOS from https://dev.mysql.com/downloads/mysql/5.5.html?os=31&version=5.1, it gets mysql_native_password plugin and in INFO_BIN WITH_AUTHENTICATION_CLIENT_PLUGINS is on. So I think Oracle do make it default already?

I can successfully connect to old version servers using native_password auth.

➜  bin ./mysql --comments -u '<user>' -h gateway01.us-east-1.dev.shared.aws.tidbcloud.com -P 4000 -D 'bikeshare' --ssl-mode=VERIFY_IDENTITY --ssl-ca=/etc/ssl/cert.pem -p'<password>' --plugin-dir=/Users/zhangyangyu/Downloads/mysql-9.0.1-macos14-arm64/lib/plugin

[thuvh]

should reopen this merge request?

[SMillerDev]

If Oracle made it the default there is nothing for Homebrew to change. If they didn't, someone should make an issue about it on their side before we re-open anything.

[zent1n0]

If Oracle made it the default there is nothing for Homebrew to change. If they didn't, someone should make an issue about it on their side before we re-open anything.

Could tell that Oracle release is shipped with this plugin enabled.

[cswingler]

Filed bug upstream: https://bugs.mysql.com/bug.php?id=116616&thanks=4

To note, the quoted documentation in #180498 is from the MySQL 9.0 server release notes, which are likely not treated as "official" documentation by upstream.

[fulghum]

@SMillerDev – Now that Oracle's MySQL support team has verified and agreed with the bug @cswingler opened, can we please reconsider accepting this patch?

I understand Homebrew doesn't want to be in the business of modifying default build config, and you're absolutely correct that the root fix is upstream. However, this issue is affecting a lot of customers and it seems worth patching quickly in Homebrew, in addition to fixing in upstream. Could we please consider an exception since this is the second most upvoted issue in the Homebrew repository?

There is strong evidence that this was an accident by Oracle and will eventually be fixed upstream:

• the MySQL-9.0 release notes call out that the mysql-9.0 client is intended to be backwards compatible and should support mysql_native_password by default.
• the official MySQL-9.0 binaries from Oracle are built with this flag and include support for mysql_native_password by default in the client.
• the MySQL support team has accepted, verified, and agreed with the upstream bug report.

We're seeing customer issue reports from Homebrew customers for our product and I know it would help a lot of other Homebrew customers to accept this patch, instead of waiting for Oracle's much slower release cycle.

Thank you for considering this! 🙏 We are very appreciative of all the work Homebrew maintainers do and I know accepting a build config patch should not be done lightly.

[SMillerDev]

@fulghum I'm happy to review a PR like this one with a link to the upstream bug report.

[fulghum]

Thank you @SMillerDev!!! 🙏

Are you able to reopen this PR if @cswingler updates the description to include the link to the accepted upstream bug report?

Or would you prefer we open a new/fresh PR with this change?

Thank you for considering an exception here!

[cswingler]

I've modified the description to add the bug report as a link.

@SMillerDev can you reopen this PR, or should I just go ahead and submit a new one?

[SMillerDev]

I can't reopen it. You'll have to make a new one.

[fulghum]

Thank you @SMillerDev! I've opened up a PR (#201679) that applies the fix to the mysql formula, to fix the client included in that formula. I'm happy to apply @cswingler's fix to the mysql-client formula as well if that first PR is accepted. Just wanted to start there since that's what most of our customers have reported using.