feat(graphql) make timeout configurable in query options #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks, can you squash the commit 141350a inside the previous one?
In additioncan you follow the commit guideline that we are inside the contributor guide?
Otherwise LGMT
ndelanou
force-pushed
the
feat/query-timeout
branch
from
141350a to
561b635
Compare
|
@vincenzopalazzo should be better now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
none
Fixes / Enhancements
queryRequestTimeoutin every option classes that extendsBaseOptions. This new parameter overrides thequeryRequestTimeoutset in theGraphQLClientconstructor.queryRequestTimeoutparameter fromGraphQLClientconstructor is now nullable. This will allow having no timeout on queries (feat(graphql): Make gql query timeout optional #1473)