feat(graphql_common): Add deduplicatePollers, deepEquals, and queryRequestTimeout parameters to copyWith method in GraphQLClient
#1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamed-rezaee
force-pushed
the
feat(graphql_common)--add-queryRequestTimeout-parameter-to-GraphQLClient
branch
from
46f08d4 to
4f0c428
Compare
hamed-rezaee
force-pushed
the
feat(graphql_common)--add-queryRequestTimeout-parameter-to-GraphQLClient
branch
from
4f0c428 to
47a1c92
Compare
hamed-rezaee
changed the title
queryRequestTimeout parameter to copyWith method in GraphQLClientdeduplicatePollers, deepEquals, and queryRequestTimeout parameters to copyWith method in GraphQLClient
vincenzopalazzo
force-pushed
the
main
branch
from
396b343 to
3628544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds
deduplicatePollers,deepEquals, andqueryRequestTimeoutparameters to thecopyWithmethod in theGraphQLClientclass. Including these parameters incopyWithallows for more consistent client cloning.Justification:
Adding
deduplicatePollers,deepEquals, andqueryRequestTimeoutparameters addresses a potential inconsistency in cloned instances.For example, the timeout might differ unexpectedly from the base client configuration. Without this cloned instances would always initialize with a
5-second timeout, which may lead to unanticipated request behavior.