feat(graphql_flutter): make first version of demo app #1204
Conversation
vincenzopalazzo
force-pushed
the
macros/flutter_chat_example
branch
2 times, most recently
from
0203e09 to
d87c8d0
Compare
vincenzopalazzo
force-pushed
the
macros/flutter_chat_example
branch
from
d87c8d0 to
81200a7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
==========================================
+ Coverage 59.61% 60.48% +0.86%
==========================================
Files 41 28 -13
Lines 1684 1435 -249
==========================================
- Hits 1004 868 -136
+ Misses 680 567 -113 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/flutter_chat_example
branch
from
81200a7 to
bc0b5f0
Compare
vincenzopalazzo
added
the
🚄 doc & examples
|
|
||
| class HomeViewBody extends StatelessWidget { | ||
| final Logger _logger = Logger(); | ||
| List<Chat> _chats = []; |
There was a problem hiding this comment.
We shouldn't store this as properties on a stateless widget.
| } | ||
|
|
||
| Widget _buildScrollView({required BuildContext context}) { | ||
| return Query( |
There was a problem hiding this comment.
IMO, I think we should advocate for hooks for readability
There was a problem hiding this comment.
Yes, my idea was making multiple example of the same app and see how it is easy use the hooks, and also this is useful at migration time, what do you think?
| return const Text("Loading chats"); | ||
| } | ||
| _logger.d(result.data ?? "Data is undefined"); | ||
| _chats = result.parsedData as List<Chat>; |
There was a problem hiding this comment.
Instead of storing the data on build, we should move the query up into the main build method and pass the data down to the children.
There was a problem hiding this comment.
I see, I will try to refactoring the code with this suggestion, thanks!
| import 'package:graphql_flutter/graphql_flutter.dart'; | ||
| import 'package:logger/logger.dart'; | ||
|
|
||
| class HomeViewBody extends StatelessWidget { |
There was a problem hiding this comment.
Should we make sure our example also has mutations?
There was a problem hiding this comment.
Yes, this required some work to do also in the API but we could integrate it
Good catch the test are just a refused because I was trying to implement integration testing, and accidentally I removed the test dir, I will reintroduce it and also make the suggestion that you had! |
vincenzopalazzo
force-pushed
the
main
branch
from
396b343 to
3628544
Compare
Continuing to split #1190
Fixes #1162
Fixes #1155
The common mistake that I make also during this demo is how we declare the link for the subscription, and I think in this case the link offers a bad API.
BTW the correct way to declare the Link in order to work with Subscriptions is the following one
Ah I was forgetting, this PR introduce also a new demo that work with the following API https://api.chat.graphql-flutter.dev based on the repository https://github.com/vincenzopalazzo/keep-safe-graphql that will be offer a lot of servers to provide integration testing server for graphql library