compiler: disallow callconv etc from depending on function parameters
#22264
+422
−871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rexicon226
reviewed
Dec 18, 2024
Just a small refactor.
mlugg
force-pushed
the
no-generic-callconv
branch
from
5e48cdc to
594ef31
Compare
mlugg
added
breaking
mlugg
force-pushed
the
no-generic-callconv
branch
from
594ef31 to
d25df63
Compare
mlugg
force-pushed
the
no-generic-callconv
branch
from
d25df63 to
1679a65
Compare
This includes function aliases, but not function declarations. Also, re-introduce a target check for function alignment which was inadvertently removed in the prior commit.
mlugg
force-pushed
the
no-generic-callconv
branch
from
1679a65 to
26aafac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even if you thought this feature was useful it really doesn't seem worth 500 damn lines of compiler logic :)
Resolves: #22261
This PR also implements a breaking change to disallow
align/linksection/addrspaceannotations on globals with comptime-only types. This includes function aliases, but not function declarations.