Add yt-dlp fallback for stream extraction #1768
Draft
+149
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the current playback issues: #1748
This is not a perfect solution:
But in my testing so far it works.
If you have a better idea feel free to share.
I tried to counter the slowness by only using this as a fallback for now.
In the long term it might be more reliable to offload more to yt-dlp.
I know the code is not the best. We can improve on that later.
However it should be fine for now as a quick fix.
Needs more testing.
TODO - before release:
- disable sending login info when using IOS client (it does not support login anymore but results in an error) DONE
TODO - for later:
Note: This also contains a temporary change to set the cookie value to null if the user is logged out (because only null is considered logged-out). It can be removed after #1694 is done.