[plugin.audio.radiofrance] v1.1.4 #4598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basrieter
requested changes
Dec 1, 2024
plugin.audio.radiofrance/default.py
Outdated
|
|
||
| DEFAULT_MANIFESTATION = 0 | ||
| RADIOFRANCE_PAGE = "https://www.radiofrance.fr" | ||
|
|
||
| CACHE_FILE = os.path.join(xbmcvfs.translatePath('special://temp/'), 'my_cache.json') |
There was a problem hiding this comment.
I would use a name that is unique to your add-on, as my_cache.json does not really identify that it belongs to your add-on and might cause issues in the future if another add-on uses the same name.
There was a problem hiding this comment.
I'd recommentd to store all addon-specific data including cache in the addon profile dir:
Addon().getAddonInfo('profile')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Robustify + speedup through http request caching and multithreading
Checklist: