Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.3cat]v1.2.0 #4590

Open
wants to merge 3 commits into
base: matrix
Choose a base branch
from
Open

[plugin.video.3cat]v1.2.0 #4590

wants to merge 3 commits into from

Conversation

mcr222
Copy link

@mcr222 mcr222 commented Oct 21, 2024

Description

Removed plugin.video.tv3.cat as it's very deprecated (catalan television completely changed their streaming website), plugin is useless as is.

Added plugin.video.3cat, which is based on the old plugin structure but it fetches from the new website (3cat.cat), with new structure and new streaming methods.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
  • If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

@mcr222 mcr222 changed the title [plugin.video.3cat]v1.1.0 [plugin.video.3cat]v1.2.0 Oct 22, 2024
@basrieter
Copy link
Contributor

Please make the add-on checker happy.

@basrieter
Copy link
Contributor

Why did you move files from the already existing addon plugin.video.tv3.cat?

@basrieter basrieter added the Don't merge PR that should not be merged (yet) label Nov 10, 2024
@mcr222
Copy link
Author

mcr222 commented Nov 18, 2024

The TV3 TV completely rebranded to 3Cat. They changed the website, and the whole streaming service. The TV3 plugin is completely deprecated and useless. The maintainer is also "gone".

So I took the project reused some of the code but threw most of it out. And renamed the plugin cause it's really different "brand".

Anyway I fixed the icon too.

@basrieter
Copy link
Contributor

basrieter commented Nov 26, 2024

The TV3 TV completely rebranded to 3Cat. They changed the website, and the whole streaming service. The TV3 plugin is completely deprecated and useless. The maintainer is also "gone".

So I took the project reused some of the code but threw most of it out. And renamed the plugin cause it's really different "brand".

Anyway I fixed the icon too.

Ok, please don't do that! You need a separate PR to only mark the other add-on as broken and submit that PR to get it merged. Then make this PR only about your new one!

Also: Please make the add-on checker happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Don't merge PR that should not be merged (yet)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants