Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary-addons build dont capture sh result completely #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fuzzard
Copy link
Contributor

@fuzzard fuzzard commented Dec 9, 2024

The actual size of the output from the capture of the stdout is pruned and not output to the jenkins log, therefore we do not actually see the entire build log of addons.

A cut from a recent webos nightly builds has the variable containing 522kb

The log shows the following output which is obviously cut short of the actual complete build step

In member function 'std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::emplace_back(_Args&& ...) [with _Args = {VFSDirEntry&}; _Tp = kodi::vfs::CDirEntry; _Alloc = std::allocator<kodi::vfs::CDirEntry>]',
    inlined from 'bool kodi::vfs::GetDirectory(const std::string&, const std::string&, std::vector<CDirEntry>&)' at /home/jenkins/jenkins-root/workspace/webos-dockerlinux_webosgles/tools/depends/target/binary-addons/arm-webos-linux-gnueabi-release/build/depends/include/kodi/Filesystem.h:908:27,
    inlined from 'static void Cache::Cleanup()' at /home/jenkins/jenkins-root/workspace/webos-dockerlinux_webosgles/tools/depends/target/binary-addons/arm-webos-linux-gnueabi-release/build/pvr.zattoo/src/http/Cache.cpp:106:31:
/home/jenkins/webos-tools/arm-webos-linux-gnueabi_sdk-buildroot/arm-webos-linux-gnueabi/include/c++/12.2.0/bits/vector.tcc:123:28: note: parameter passing for argument of type '__gnu_cxx::__normal_iterator<kodi::vfs::CDirEntry*, std::vector<kodi::vfs::CDirEntry> >' changed in GCC 7.1
  123 |           _M_realloc_insert(end(), std::forward<_Args>(__args)...);
      |           ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[Pipeline] writeFile
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage

The .last_failed_revision seems to not be used as far as i can find, and because of the pruned output in the result var, wont ever currently tag a failure

The addon badge status is still pulled from $WORKSPACE/cmake/addons/.failure and .success, so the badge output shouldnt be affected by this at all.

@fuzzard fuzzard requested a review from wsnipex December 9, 2024 03:19
The actual size of the output from the capture of the stdout is pruned and not output
to the jenkins log, therefore we do not actually see the entire build log of addons.

The .last_failed_revision seems to not be used as far as i can find, and because of the
pruned output in the result var, wont ever currently tag a failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant