Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refetch store len to be safe against rollbacks #771

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refetch store len to be safe against rollbacks #771

wants to merge 1 commit into from

Conversation

eaypek-tfh
Copy link
Collaborator

Change

  • Upon inconsistencies, we rollback storage upon start. Then, we load the iris records db into memory. We have some checks to ensure that the loading was correct. However, they used to depend on the old store length. This PR re-fetches store len before loading starts
  • It also denies to load items from s3 which exceed the max serial id in db - those records could be rolled back

@github-actions github-actions bot added the patch label Dec 9, 2024
@eaypek-tfh eaypek-tfh force-pushed the fix/refetch-store-len-to-be-safe-against-rollbacks branch from b791ece to 88fa6c4 Compare December 9, 2024 00:56
@eaypek-tfh eaypek-tfh requested a review from philsippl December 9, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philsippl philsippl Awaiting requested review from philsippl

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eaypek-tfh