feat: add node-version-file option
#48
Conversation
| node-version-file: | ||
| description: "You may specify file path where node version is defined (e.g. package.json, .nvmrc, .node-version, .tool-versions.)" | ||
| required: false | ||
| default: "" |
There was a problem hiding this comment.
Description is based on that of actions/setup-node@v4 and package-manager option.
|
I see where this is coming from, but we shouldn't expose every option from sub-actions. That would become very unruly, and the goal here is to have a small number of inputs to provide quick onboarding for the majority of simple use cases. If you have a more complex setup that this action supports, we recommend writing your own custom GitHub Action. |
|
@natemoo-re I understand your concern about not wanting to expose every possible option, but imo it's a pretty common pattern to have a file define the Node version that a project uses. A lot of Node tooling is built around this sort of thing. I may be being reductive here, but I feel like supporting this option wouldn't necessarily open up a can of worms that would drastically increase complexity. |
Resolves #47
This PR includes trailing spaces removal on save.