Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-windicss): fix vite5 hmr #326

Merged
merged 4 commits into from
Dec 25, 2023
Merged

Conversation

markthree
Copy link
Contributor

@markthree markthree commented Dec 24, 2023

In vite5, watchChange is triggered before hmr even if the devServer is started, which causes the hot update to fail, add the inHmr flag to skip the repeat trigger (as in vite4)

I simply tested vite4 and vite5 in the local area, and now their HMR works well.
If there is any case, I was ignored, please tell me. 🤣

Maybe there are stricter restrictions here, even specific to the vite version

@antfu antfu merged commit 29cbb86 into windicss:main Dec 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants