Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default slurm arguments to None #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

colligant
Copy link

Currently the SlurmCluster object builds a slurm script with some default parameters (time=15:00, per_experiment_nb_gpus=1, etc). This PR changes the behavior so users have to specify which slurm directives they want to use. I think there are two reasons for this change:

  1. Slurm managed clusters often have sensible defaults for parameters that are not specified in the slurm script.
  2. The default parameters aren't mentioned in the docs (unless I missed something), and their configuration caused my script to fail. Debugging was easy enough but I think explicitly specifying needed parameters in the SlurmCluster object is a better choice than setting defaults in the object.

Thanks for this tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant