-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename http3Only to requireUnreliable #1745
Conversation
This should be more future proof. Fixes #1744.
Given this work-in-progress "Quic for Streams" draft https://www.ietf.org/archive/id/draft-kazuho-quic-quic-on-streams-00.html ... which would allow implementing a functional subset of QUIC on top of TLS, I'm not sure "requireUnreliable" makes sense |
@jasnell presumably a WebTransport user that sets |
What does |
That's the term https://w3c.github.io/webtransport/ uses as public API and it's for them, so might as well stick with it. What it means is described in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This seems like it strikes a good balance between describing the needs at a high level and being clear and precise enough for implementation at a lower level.
Thanks! I've pushed mt's suggestion. I will merge this on Monday barring any other comments. |
Thanks, given there's been feedback that resulted in further changes I will merge it this week Thursday now to give everyone a chance to look again. |
This should be more future proof.
Fixes #1744.
Preview | Diff