Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger negative offsets #234

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vafu
Copy link

@vafu vafu commented Oct 6, 2020

This PR enables negative offsets for triggers/gates.
General concept is to calculate next step on current tick to put negatively offsetted trigger closer to current tick in the queue.

Changes

  • modify SequenceState
    -- add nextStep, nextIteration, calclulateNextStep*. move existing
    -- move existing advanceNextStep* logic to calculateNextStep* and reimplement advanceNextStep* to use calculated values
  • modify NoteTrackEngine:
    -- make triggerStep aware if it's triggering current step or scheduling for future
    -- use negative offset in triggerStep

TODO

  • tests
  • more testing

P.S. I'm not familiar with c++, so I'd appreciate any help with unit test system here

@vafu vafu changed the title [WIP] Add trigger negative offsets Add trigger negative offsets Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant