Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix plugin test suite #174

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
Test update

Did you add tests for your changes?
This PR aims at fixing the failing test suite.

If relevant, did you update the documentation?
N/A

Summary
Fixes failing test suite.

Does this PR introduce a breaking change?
No

Other information
N/A

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #174 (aee4d01) into master (31454ea) will increase coverage by 18.68%.
The diff coverage is 51.28%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #174       +/-   ##
===========================================
+ Coverage   56.56%   75.25%   +18.68%     
===========================================
  Files           3        3               
  Lines         198      198               
  Branches       37       37               
===========================================
+ Hits          112      149       +37     
+ Misses         69       42       -27     
+ Partials       17        7       -10     
Impacted Files Coverage Δ
src/plugin.js 55.43% <51.28%> (+40.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31454ea...aee4d01. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep only webpack v5 compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants