feat(admin-ui): AutoComplete + MultiAutoComplete components #4459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # yarn.lock
# Conflicts: # packages/admin-ui/src/Button/Button.stories.tsx # packages/admin-ui/src/Select/SelectPrimitive.tsx # packages/admin-ui/src/Tag/Tag.stories.tsx # packages/admin-ui/src/Tag/Tag.tsx
|
/storybook |
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
|
Jest tests have been initiated (for more information, click here). ✨ |
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
|
Jest tests have been initiated (for more information, click here). ✨ |
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
|
Jest tests have been initiated (for more information, click here). ✨ |
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
|
🚀 Storybook Preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces two new components and improves many others
AutoComplete + MultiAutoComplete
These two new components are based on the
Commandcomponent, a wrapper around cmdk. This component can also serve as a foundation forOmniSearchcomponent. Currently, it is kept private and not exposed outside@webiny/admin-ui.Other improvements
Source Sans Profont from the admin, the rest of RMWC SCSS variables are still in place.reset.scssfile.reffrom the component.inputRefprop, improved how the icons position is handled and removed the possibility of decorating the primitive component.textareaRefprop and removed the possibility of decorating the primitive component.How Has This Been Tested?
Manually + Jest