feat(admin-ui): Tag + Icon Button components #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/ui/package.json # yarn.lock
leopuleo
changed the title
adrians5j
approved these changes
Dec 19, 2024
| @@ -5,7 +5,7 @@ import { cn, cva, VariantProps, makeDecoratable } from "~/utils"; | |||
| const buttonVariants = cva( | |||
| [ | |||
| "border-transparent rounded font-sans inline-flex items-center justify-center whitespace-nowrap ring-offset-background transition-colors", | |||
| "disabled:pointer-events-none", | |||
| "disabled:cursor-not-allowed", | |||
There was a problem hiding this comment.
I love the not allowed cursor.. but do we need to remove pointer-events-none here? Wouldn't the user still be able to click on the button now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request adds the
TagandIconButtoncomponents to the@webiny/admin-uipackage.IconButton
This component is used when we want to show a simple button with an Icon.
In this PR, we are also:
iconSizeprop from theButtoncomponent.IconButtonto several other components, such asTag,Card,Select,Alert, andToast.@webiny/ui/Buttoncomponent; some (i.e.flatorsmall) were passed to the new@webiny/admin-ui/Buttoncomponent, causing console warnings.Tag
A visual element used to display brief, contextual information or status. The developers can:
onClickcallback.onDismisscallback.dismissIconElementanddismissIconLabelprops.Icon
The
Iconcomponent should be used internally whenever an icon is displayed. Sometimes, we want to set theIconfill colour to the parent for more granular control. For this reason, the default colour prop isinherit.