fix: fix form builder settings after switching to new locale #3546
Conversation
| import { ContextPlugin } from "@webiny/api"; | ||
| import { FormBuilderContext } from "~/types"; | ||
|
|
||
| export const createSettingsForNewLocale = new ContextPlugin<FormBuilderContext>(context => { |
There was a problem hiding this comment.
Once a locale has been deleted, let's also delete settings.
| context.i18n.locales.onLocaleAfterCreate.subscribe(async ({ locale }) => { | ||
| const existingSettings = await context.formBuilder.getSettings({ | ||
| auth: false, | ||
| locale: locale.code |
There was a problem hiding this comment.
Do we really need locale here? Wouldn't the current locale automatically be pulled above?
If there's no really a need to expose locale param, let's maybe not do it.
|
@adrians5j While adding similar changes to PB I've noticed that there is no delete option in PB settings crud (FB settings crud has it). Should we add one? Then we will be able to delete settings after the locale is deleted (just like we do in FB now). |
|
Yes, let's do it @neatbyte-vnobis . Thanks! |
|
@adrians5j Currently, the FB/HCMS PR is focused on migrating only The FB-related changes can be included in the FB/HCMS PR, and, as you've suggested, the PB part can be moved to a separate PR. |
|
@adrians5j Any updates on this one? Should we move PB changes to a separate PR or leave it as it is? |
Changes
Resolve issue: Unable to submit a form in newly created locale.
Form submission was throwing
"Form Builder" settings not found!error, since there were noForm Buildersettings created for the new locale. This also caused the same issue when savingForm Buildersettings form.Issue was resolved by triggering
Form Buildersettings creation, when a newlocaleis created.While fixing this issue I've found that the same is happening for the
Websitesettings form, sinceWebsitesettings are also not created for newlocale. If this fix is ok, then something similar can be done insideapi-page-builderto create settings after a newlocaleis created.Also while testing this fix I've noticed that after switching to a new
localeuser is unable to create any pages until a page category withstaticslug is created. Is this expected behavior?@adrians5j @Pavel910 What do you think?
How Has This Been Tested?
Manual
Documentation
None