remove invalid namefrom contents expectations for li #45867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
fantasai,
jnurthen,
kojiishi,
MelSumner,
spectranaut and
tabatkins
cookiecrook
force-pushed
the
invalid-li-name-from-contents
branch
from
d6ed648 to
ee9e4d3
Compare
cookiecrook
commented
Apr 24, 2024
| <li data-expectedrole="listitem" data-expectedlabel="x" data-testname="listitem within ul with display: contents, as child of div with display: grid, has listitem role" class="ex-role-and-label">x</li> | ||
| <li data-expectedrole="listitem" data-testname="listitem within ul with display: contents, as child of div with display: grid, has listitem role" class="ex-role">x</li> |
There was a problem hiding this comment.
Reviewers, hopefully the diff is self-explanatory, but to explain the line-by-line CI results, you'll see the following:
- 9 new role tests in the first section (testnames without a Label: or Role: prefix), then
- 9 missing results in the "Label:"-prefixed test list, then
- 9 missing results in the "Role:"-prefixed test list.
So the CI results look like 27 test changes, even though there are only 9 lines changed in the diff. It's just an artifact of the test name and ordering of the function calls.
HTH with the one confusing part of an otherwise straightforward review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes web-platform-tests/interop-accessibility#118
Previous label tests assumed ARIA namefrom:contents was available on list item roles... There is an open ARIA issue #2160 that might clarify this, but for Interop 2024, these few test expectations did not match the current ARIA spec, so we're removing them.