Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Pipelines] drop old workaround for safaridriver --version #18454

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

foolip
Copy link
Member

@foolip foolip commented Aug 15, 2019

The --version argument is supported starting in Safari 12.1:
web-platform-tests/results-collection#617

@wpt-pr-bot wpt-pr-bot requested a review from jgraham August 15, 2019 10:46
@foolip foolip requested a review from gsnedders August 15, 2019 10:46
@foolip
Copy link
Member Author

foolip commented Aug 15, 2019

I've started https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=27261 to test this, to see if what shows up in wpt.fyi has the right version as hoped.

@foolip
Copy link
Member Author

foolip commented Aug 15, 2019

https://wpt.fyi/results/?run_id=286580001 is the run that resulted from this, showing that it works :)

@foolip foolip merged commit a2d1acf into master Aug 21, 2019
@foolip foolip deleted the foolip/azure-safaridriver-version branch August 21, 2019 08:29
natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants