Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web MIDI: reflect spec's [SecureContext] to relevant .idl files #17520

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 26, 2019

This is a follow up to disallow Web MIDI uses on insecure origins.
After this change, the Web MIDI related interfaces won't appear
on insecure origins.

WebAudio/web-midi-api#183
WebAudio/web-midi-api#199

Bug: 924471
Change-Id: I61d55d5ba192a6cbcea9e29f97c4bfe11ac4b983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673491
Commit-Queue: Takashi Toyoshima <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#672474}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

This is a follow up to disallow Web MIDI uses on insecure origins.
After this change, the Web MIDI related interfaces won't appear
on insecure origins.

WebAudio/web-midi-api#183
WebAudio/web-midi-api#199

Bug: 924471
Change-Id: I61d55d5ba192a6cbcea9e29f97c4bfe11ac4b983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673491
Commit-Queue: Takashi Toyoshima <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#672474}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 12b6e03 into master Jun 27, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1673491 branch June 27, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants