Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Connection Figures #1201

Merged
merged 19 commits into from
Aug 2, 2024
Merged

Initial Connection Figures #1201

merged 19 commits into from
Aug 2, 2024

Conversation

egekorkan
Copy link
Contributor

@egekorkan
Copy link
Contributor Author

@lu-zero I have updated your drawings as well but did not export yet. Feel free to edit the drawio file and push them here

@egekorkan
Copy link
Contributor Author

I have added diagrams from @relu91

@egekorkan
Copy link
Contributor Author

@relu91 I am done with the adjustments so you can take over. Once you are done, @lu-zero can do the proxy diagrams

@egekorkan egekorkan mentioned this pull request Jul 25, 2024
Merged
@relu91 relu91 mentioned this pull request Jul 31, 2024
Merged
@egekorkan
Copy link
Contributor Author

@lu-zero you can add your diagrams here now

egekorkan
egekorkan commented Jul 31, 2024
View reviewed changes
planning/ThingDescription/td-next-work-items/usability-and-design.md Outdated

###### Lifecycle of a Connection

TODO
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lu-zero to add lifecycle diagram

planning/ThingDescription/td-next-work-items/usability-and-design.md Outdated

###### Message Sequence

![Message Sequence](./images/initial-connection-Proxy-sequence.png)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lu-zero to add a 5 minute time component

@lu-zero lu-zero force-pushed the ege-initial-connection branch from dcb8d3d to f2cbb20 Compare August 1, 2024 13:18
@egekorkan
Copy link
Contributor Author

Call of 01 Aug:

  • One broken link to fix in Websocket
  • All images to be turned to SVG
  • Conflicts should be resolved

These small issues will be fixed async and this PR will be merged. Then, before next call, these diagrams can be moved to the TD repository.

@egekorkan
Copy link
Contributor Author

Small issues fixed. Merging

@egekorkan egekorkan merged commit c3d149e into main Aug 2, 2024
@egekorkan egekorkan deleted the ege-initial-connection branch August 2, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egekorkan @relu91 @lu-zero