TM Regex fix #1912
Merged
TM Regex fix #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egekorkan
added
Editorial
|
Is this update for TD 2.0 (next version) or is the intention here to update the published resources for TD 1.1? If the latter, this should be made clear and we probably need a resolution in the main call, etc. Personally... without a clear call for resolution in the main call, I think this should NOT go into the resources for TD 1.1. |
|
Call of 02.11: We have removed the formatting change since it was added by mistake (done by my IDE). The change is only to the regex so that more regex libraries support it. Thus, there should be no breaking changes to implementations. We can have a main call resolution to merge it. Once merged, it will be copied over to wot-resources. |
|
We have agreed to merge it in the main call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1906 (discussion is there)