Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary triple quotes around comments #1901

Merged
merged 1 commit into from
Oct 18, 2023
Merged

unnecessary triple quotes around comments #1901

merged 1 commit into from
Oct 18, 2023

Conversation

mahdanoura
Copy link
Contributor

@mahdanoura mahdanoura requested a review from egekorkan October 18, 2023 12:56
@danielpeintner
Copy link
Contributor

Out of curiosity I checked when to use triple quotes and when not to do so. Apparently one has to use triple quotes for "newlines"... maybe also in other cases. Having said that, it is not wrong per se to have them always. It might be even safer to do so...

Anyhow, no objection to merge as is.

@mahdanoura
Copy link
Contributor Author

mahdanoura commented Oct 18, 2023 •
edited
Loading

Out of curiosity I checked when to use triple quotes and when not to do so. Apparently one has to use triple quotes for "newlines"... maybe also in other cases. Having said that, it is not wrong per se to have them always. It might be even safer to do so...

Anyhow, no objection to merge as is.

It's not incorrect to do so, but as I write they are unncessary. It also causes the usual SyntaxError: invalid syntax, when trying to parse the ontology. I was trying a SCHACL library and came across this.

@egekorkan egekorkan linked an issue Oct 18, 2023 that may be closed by this pull request
Unnecessary triple quotes around comments #1898
Closed
@egekorkan egekorkan added the Editorial Issues with no technical impact on implementations label Oct 18, 2023
@egekorkan
Copy link
Contributor

Call of 18.10: This does not result in any changes in the index.html (when run locally). The TF is fine to merge and then @egekorkan will copy over to the wot-resources

@egekorkan egekorkan merged commit f54f506 into w3c:main Oct 18, 2023
This was referenced Oct 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egekorkan egekorkan Awaiting requested review from egekorkan

Assignees
No one assigned
Labels
Editorial Issues with no technical impact on implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary triple quotes around comments
3 participants
@mahdanoura @danielpeintner @egekorkan