Add CDDL validation using cddlparser and pyodide #837
Merged
+249
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no immediate parser in Node.js that could be used to validate CDDL extracts. Instead, the idea is to run the cddlparser Python package using a Python interpreter running in WebAssembly. This provides a CDDL validation guarantee for Webref. Some notes: - The version of cddlparser used by Strudy is specified in the `requirements.txt` file. Goal is for Dependabot to create a pull request automatically when a new version becomes available. - Loading could be optimized not to depend on `micropip` at all, but that requires hardcoding the Wheel URL of the cddlparser package somehow. - The line position in the anomalies report needs to be adjusted to account for the header that Reffy adds and that gets stripped during "expansion". That's hardcoded for now. I'd say that's good enough... - The CDDL parser stops as soon as it encounters an error, the list of anomalies only contains the first problem as a result. - The CDDL parser does not validate additional CDDL semantics for now.
Recent crawl results should have a `cddl` property for each and every spec, but previous crawl results and test data do not.
tidoust
added a commit
that referenced
this pull request
Dec 19, 2024
New features: - Add CDDL validation using cddlparser and pyodide (#837) - Add detection of IDL attributes for URL with wrong type (#836) - Ignore text fragment directive in link comparison - Run IDL analyses on curated branch, enable noEvent - Web IDL study: detect event handlers with no matching event (#785) - Adjust --update-mode options - New `--cc` option to copy people in issues (#732) Dependencies bumped: - Bump mocha from 10.7.3 to 11.0.1 - Bump reffy from 17.2.2 to 18.1.1 - Bump @octokit/plugin-throttling from 9.3.1 to 9.3.2 - Bump @actions/core from 1.10.1 to 1.11.1 - Bump jsdom from 25.0.0 to 25.0.1 - Update jsdom version to avoid noisy deprecation notice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no immediate parser in Node.js that could be used to validate CDDL extracts. Instead, the idea is to run the cddlparser Python package using a Python interpreter running in WebAssembly.
This provides a CDDL validation guarantee for Webref.
Some notes:
requirements.txtfile. Goal is for Dependabot to create a pull request automatically when a new version becomes available.micropipat all, but that requires hardcoding the Wheel URL of the cddlparser package somehow.