-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply the new design to the guidebook #267
base: main
Are you sure you want to change the base?
Conversation
/cc @caribouW3 |
It would be far easier to review this if there were a pr-preview or similar. What are the chances such could be instituted? |
@TallTed it might be difficult to integrate this with pr-preview. pr-preview works for specs that use a generator such as respec and bikeshed and it's meant to preview a single file. |
OK, pr-preview isn't a suitable tool, here. That possibility is why I said "or similar". |
chair/meetings.md
Outdated
</div> | ||
|
||
<blockquote style="margin-top: 5em;"> | ||
<blockquote> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a quote component in the theme that is more suitable here: https://w3c.github.io/w3c-jekyll-theme/components.html#quote
- Make it clear when feedback and comments are wanted, and let people know how to do so. | ||
- Share the intended message with the rest of the elected body you are a member of before you send it. | ||
|
||
### Revision History |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Revision History | |
## Revision History |
council/council.md
Outdated
such communications take place and the process continues to move forward.</p></dd> | ||
</dl> | ||
|
||
### Revision History |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Revision History | |
## Revision History |
This reverts commit f9d189b.
…nge the header levels
This is a HUGE change to the document. It's near impossible to coherently review, made worse by the apparent mix of markup and content changes. I cannot recommend strongly enough that this PR be re-attempted as multiple PRs, breaking it into at least changes to content and changes to markup, if not into multiple PRs comprising each of these. Lacking such breakup, it is all but certain that unintended changes will go undetected. |
@lcarcone @vivienlacourba, I'm starting this PR to redesign the guidebook.
I've redesigned 2 pages for the example:
Happy to schedule a call to discuss the details with you