Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler-vapor): support v-on for component #175

Merged
merged 10 commits into from
Apr 14, 2024

Conversation

Doctor-wu
Copy link
Member

related #4

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 5e76c41
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/661c22db3b44e600096a8882
😎 Deploy Preview https://deploy-preview-175--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 5e76c41
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/661c22db3516160008d99f2d
😎 Deploy Preview https://deploy-preview-175--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 11, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 49.4 kB (+288 B) 16.8 kB (+82 B) 15.3 kB (+88 B)
runtime-dom.global.prod.js 94.5 kB 35.6 kB 32 kB
runtime-vapor.global.prod.js 42.8 kB 15.9 kB 14.6 kB
vue-vapor.global.prod.js 89.6 kB (+180 B) 31.3 kB (+55 B) 28.3 kB (+11 B)
vue.global.prod.js 152 kB 54.9 kB 49 kB

Usages

Name Size Gzip Brotli
createApp 54.8 kB 21 kB 19.2 kB
createSSRApp 58.1 kB 22.3 kB 20.4 kB
defineCustomElement 57.1 kB 21.8 kB 19.9 kB
vapor 43.1 kB 15.9 kB 14.6 kB
overall 68.5 kB 26.1 kB 23.6 kB

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some unit tests

packages/compiler-vapor/src/transforms/vOn.ts Outdated Show resolved Hide resolved
@sxzz sxzz changed the title feat(compiler-vapor, runtime-vapor): support listen sub components emit feat(compiler-vapor): support listen sub components emit Apr 14, 2024
@sxzz sxzz merged commit a49b6f9 into vuejs:main Apr 14, 2024
8 checks passed
@sxzz sxzz changed the title feat(compiler-vapor): support listen sub components emit feat(compiler-vapor): support v-on for component Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants