-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime-vapor): component slot #143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size ReportBundles
Usages
|
ubugeeei
force-pushed
the
ubugeeei/feat/component-slot
branch
from
March 17, 2024 08:14
6922775
to
e967ed1
Compare
ubugeeei
force-pushed
the
ubugeeei/feat/component-slot
branch
from
March 17, 2024 11:09
68114ef
to
0159af9
Compare
sxzz
reviewed
Mar 22, 2024
…vapor into ubugeeei/feat/component-slot
Thank you for the very thorough review! 😄 |
sxzz
reviewed
Mar 23, 2024
sxzz
reviewed
Mar 23, 2024
sxzz
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #53
relates #4
I've implemented component slots (runtime only)
already followed up on the changes in #151.
and created compiler issue -> #154
- [ ] warning❌ (marked as TODO)tests
※ For now, I am implementing it based on runtime-core/test/componentSlots.spec.ts, but I was unsure about the necessary tests or test case names, and for parts I couldn't implement, I've added TODOs, so I'd like to ask for confirmation! 🙏
Some things might be okay to delete. Please comment on anything unnecessary. I will delete them in this PR.
refactor dynamic slots
Example...
2024-03-17.19.54.15.mov