feat: add repository and link for external translations #4184
+154
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userquin
commented
Sep 6, 2024
userquin
commented
Sep 6, 2024
|
Should we add the hover effect on mobile screen? |
|
/publish |
commit: |
userquin
commented
Sep 6, 2024
src/client/theme-default/components/VPNavScreenTranslations.vue
Outdated
Show resolved
Hide resolved
|
Review gitlab and bitbacket svg icons, links in the css: |
|
How do I do that
…On Fri, Sep 6, 2024, 11:18 AM Joaquín Sánchez ***@***.***> wrote:
Description
This PR allows to include the github repository link in the translations
navbar and mobile.
@brc-dd <https://github.com/brc-dd> I'm updating the mobile translation
component (VPNavScreenTranslations)
Linked Issues Additional Context
Something similar to Vue VP theme and the translation thing.
------------------------------
Tip
The author of this PR can publish a *preview release* by commenting
/publish below.
------------------------------
You can view, comment on, or merge this pull request online at:
#4184
Commit Summary
- d4938bc
<d4938bc>
feat: add repository and link for external translations
File Changes
(6 files <https://github.com/vuejs/vitepress/pull/4184/files>)
- *M* __tests__/e2e/.vitepress/config.ts
<https://github.com/vuejs/vitepress/pull/4184/files#diff-a7061f07ab6f5b99e8aa7e4d0c13c357f9bbcc77ce46b99d32b10fd86df8452d>
(8)
- *M* src/client/theme-default/components/VPMenuLink.vue
<https://github.com/vuejs/vitepress/pull/4184/files#diff-c1f6cffbd37625cd29c02ffee12820d5f0e31ec0ca17327631df288fecbdaa00>
(4)
- *M* src/client/theme-default/components/VPNavBarTranslations.vue
<https://github.com/vuejs/vitepress/pull/4184/files#diff-c137efb6c46099e254a011e64211d4cdf23652a76aa461a05d55948a11dac520>
(25)
- *M* src/client/theme-default/components/VPNavScreenTranslations.vue
<https://github.com/vuejs/vitepress/pull/4184/files#diff-03bf1421ec27e0b7ee3476e2682fa7d2ac8c2b5e35a70b0892b9107e3042e688>
(2)
- *M* src/client/theme-default/composables/langs.ts
<https://github.com/vuejs/vitepress/pull/4184/files#diff-5a628d1968485980dfc86e06a4a9ed3ed19a912261045f65d3e343e57ad91a97>
(37)
- *M* types/shared.d.ts
<https://github.com/vuejs/vitepress/pull/4184/files#diff-c49d44f5de785f48fedb3288501392be3b8dc14f26d017c2b0d1fc6f5afb8d5d>
(11)
Patch Links:
- https://github.com/vuejs/vitepress/pull/4184.patch
- https://github.com/vuejs/vitepress/pull/4184.diff
—
Reply to this email directly, view it on GitHub
<#4184>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BESSWVSPUCYCEUVIT2SDS7DZVHIWHAVCNFSM6AAAAABNY4OUFGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTANZYGMZTENI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
What do you mean? |
userquin
commented
Sep 6, 2024
userquin
commented
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to include the github repository link in the translations navbar and mobile.
@brc-dd I'm updating the mobile translation component (VPNavScreenTranslations) ✅ done
Linked Issues
Additional Context
Something similar to Vue VP theme localeLinks: check translations in the vue docs here https://vuejs.org/
Tip
The author of this PR can publish a preview release by commenting
/publishbelow.