Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown/table): use Token.attr[Get|Join] insteed the hardcode tabindex attr #4082

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheNorthMemory
Copy link

@TheNorthMemory TheNorthMemory commented Jul 28, 2024

markdown-it-attrs supported extra attributes for eg: {tabindex=1} after table block, fix it.

Description

return '<table tabindex="0">\n'

Additional Context

refer: https://markdown-it.github.io/markdown-it/#Token.attrGet and https://markdown-it.github.io/markdown-it/#Token.attrJoin

@TheNorthMemory
Copy link
Author

Hi there, this site https://wechatpay.im, is strictly rely on this function, because there were more than 1000+ markdown tables rended. Hopes this fix shall be merged.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant