-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve printing experience. #4041
Open
7086cmd
wants to merge
8
commits into
vuejs:main
Choose a base branch
from
7086cmd:feat/printing-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7086cmd
changed the title
feat: remove navs and footers in printing mode. [WIP]
feat: improve printing experience. [WIP]
Jul 14, 2024
7086cmd
changed the title
feat: improve printing experience. [WIP]
feat: improve printing experience.
Jul 14, 2024
So strange. Local code are formatted, but online repo reported errors. |
You seem to be using different prettier version. Try re-running pnpm install. Then pnpm format. |
@brc-dd It works. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, we may need to print documents as PDFs, using mdbook as an example. While certain components can be omitted during printing, there are situations where we might want to retain them. To address this, I am introducing an option to manage these components.
In the current implementation, I use the
important
key to emphasize hiding certain elements, which may lead to unintended side effects. I plan to remove these commands to avoid such issues.Before
After
With the
removeExtraElementsInPrint
option inDefaultTheme.Config
, users can decide whether to keep or omit specific components during printing. Additionally, I have modified the dark mode switch function to automatically switch to light mode when thebeforeprint
event is triggered.Let me know if any further changes are needed!