Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility with ESLint v9 (take2) #2338

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Improve compatibility with ESLint v9 (take2) #2338

merged 2 commits into from
Dec 1, 2023

Conversation

ota-meshi
Copy link
Member

This PR is a follow-up PR for #2331.
I checked again and found that it still uses APIs that will be removed in ESLint v9. This PR aims to refactor those source codes to improve compatibility with ESLint v9.

lib/rules/jsx-uses-vars.js Outdated Show resolved Hide resolved
typings/eslint/index.d.ts Outdated Show resolved Hide resolved
@ota-meshi
Copy link
Member Author

I have changed this PR. Could you check it again?

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@ota-meshi ota-meshi merged commit 77af4b4 into master Dec 1, 2023
16 checks passed
@ota-meshi ota-meshi deleted the compat-v9 branch December 1, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants