Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): Better typescript support for emit events #2164

Open
wants to merge 16 commits into
base: minor
Choose a base branch
from

Conversation

pikax
Copy link
Member

@pikax pikax commented Sep 19, 2020

Requires [email protected]

NOTE: There's some build errors when updating to [email protected], this PR is not meant to fix those errors, only to implement string type inference

image
image
image
image

@yyx990803 yyx990803 added the 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. label Dec 4, 2020
@pikax pikax marked this pull request as ready for review December 19, 2020 13:17
@pikax
Copy link
Member Author

pikax commented Dec 19, 2020

I believe the build is failing because of usage of Typescript ^4.1.x with @microsoft/api-extractor

@yyx990803
Copy link
Member

@pikax mind rebasing on latest 3.2 branch?

@yyx990803 yyx990803 changed the base branch from master to 3.2 July 16, 2021 14:00
pikax added 2 commits July 16, 2021 15:41
# Conflicts:
#	packages/runtime-core/src/component.ts
#	packages/runtime-core/src/componentOptions.ts
#	packages/runtime-core/src/componentProps.ts
@edison1105 edison1105 changed the base branch from 3.2 to minor September 9, 2024 08:35
@edison1105
Copy link
Member

Could you please resolve those conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: types version: minor
Projects
Status: Needs Review
4 participants