-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): add type-aware rules #12497
base: minor
Are you sure you want to change the base?
Conversation
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-ssr
@vue/compiler-dom
@vue/compiler-sfc
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →
|
@@ -159,7 +158,7 @@ export const transformFor: NodeTransform = createStructuralDirectiveTransform( | |||
: isTemplate && | |||
node.children.length === 1 && | |||
isSlotOutlet(node.children[0]) | |||
? (node.children[0] as SlotOutletNode) // api-extractor somehow fails to infer this | |||
? node.children[0] // api-extractor somehow fails to infer this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this comment referring to the now removed assertion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this comment means. This comment was added in b685805, I reset to that commit and confirmed that the type of children[0]
is not SlotOutletNode
, so I think this comment may be not related to the removed assertion.
Exploration move to tsslint to use type-aware rules in a high-performance manner.
I tested all type-aware rules of
typescript-eslint
and added the ones with no friction from Vue core: