Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1356 srcapicustom elementsmd #1357

Merged
merged 17 commits into from
Sep 21, 2024
Merged

1356 srcapicustom elementsmd #1357

merged 17 commits into from
Sep 21, 2024

Conversation

tisma95
Copy link
Collaborator

@tisma95 tisma95 commented Sep 18, 2024 •
edited
Loading

Actions à effectuer :

  • Vérifier que le nombre de lignes supprimées égale le nombre de lignes ajoutées
  • Mettre en cohérence toute référence à la page traduite qui serait présente sur d'autres pages
  • Mettre à jour le lien du menu
  • Lier la PR à une issue
    Closes #

Remarques:
J'ai des doutes sur la traduction shadow root. Je pense qu'on peut avoir mieux que la racine d'ombre @edimitchel as tu une idée ?

@tisma95 tisma95 added the documentation Improvements or additions to documentation label Sep 18, 2024
@tisma95 tisma95 requested a review from edimitchel September 18, 2024 15:45
@tisma95 tisma95 self-assigned this Sep 18, 2024
@tisma95 tisma95 linked an issue Sep 18, 2024 that may be closed by this pull request
src/api/custom-elements.md #1356
Closed
@stackblitz StackBlitz
Copy link

stackblitz bot commented Sep 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-fr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 10:39pm

edimitchel
edimitchel requested changes Sep 18, 2024
View reviewed changes
src/api/custom-elements.md Outdated Show resolved Hide resolved
src/api/custom-elements.md Outdated Show resolved Hide resolved
src/api/custom-elements.md Outdated Show resolved Hide resolved
src/api/custom-elements.md Outdated Show resolved Hide resolved
tisma95 and others added 3 commits September 19, 2024 16:59
@tisma95 @edimitchel
Update src/api/custom-elements.md
a7209c1 
Co-authored-by: Michel EDIGHOFFER <[email protected]>
@tisma95 @edimitchel
Update src/api/custom-elements.md
500d45b 
Co-authored-by: Michel EDIGHOFFER <[email protected]>
@tisma95 @edimitchel
Update src/api/custom-elements.md
1955adf 
Co-authored-by: Michel EDIGHOFFER <[email protected]>
tisma95
tisma95 commented Sep 19, 2024
View reviewed changes
src/api/custom-elements.md Outdated Show resolved Hide resolved
src/api/custom-elements.md Outdated Show resolved Hide resolved
src/api/custom-elements.md Outdated Show resolved Hide resolved
@tisma95 tisma95 requested a review from edimitchel September 19, 2024 15:06
@edimitchel
Copy link
Collaborator

Shadow root doit être gardé

tisma95
tisma95 commented Sep 19, 2024
View reviewed changes
src/api/custom-elements.md Outdated Show resolved Hide resolved
src/api/custom-elements.md Outdated Show resolved Hide resolved
tisma95
tisma95 commented Sep 19, 2024
View reviewed changes
src/api/custom-elements.md Outdated Show resolved Hide resolved
src/api/custom-elements.md Outdated Show resolved Hide resolved
src/api/custom-elements.md Outdated Show resolved Hide resolved
src/api/custom-elements.md Outdated Show resolved Hide resolved
tisma95
tisma95 commented Sep 20, 2024
View reviewed changes
Copy link
Collaborator Author

@tisma95 tisma95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changement racine d'ombre par shadow root

edimitchel
edimitchel requested changes Sep 20, 2024
View reviewed changes
src/api/custom-elements.md Outdated Show resolved Hide resolved
src/api/custom-elements.md Outdated Show resolved Hide resolved
tisma95 and others added 2 commits September 21, 2024 10:41
@tisma95 @edimitchel
Update src/api/custom-elements.md
2505016 
Co-authored-by: Michel EDIGHOFFER <[email protected]>
@tisma95 @edimitchel
Update src/api/custom-elements.md
caf03b8 
Co-authored-by: Michel EDIGHOFFER <[email protected]>
@tisma95 tisma95 requested a review from edimitchel September 21, 2024 08:41
@tisma95 tisma95 added need review and removed documentation Improvements or additions to documentation labels Sep 21, 2024
edimitchel
edimitchel requested changes Sep 21, 2024
View reviewed changes
src/api/custom-elements.md Outdated Show resolved Hide resolved
@edimitchel edimitchel merged commit 858dc4a into main Sep 21, 2024
3 checks passed
@edimitchel edimitchel deleted the 1356-srcapicustom-elementsmd branch September 21, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edimitchel edimitchel edimitchel approved these changes

Assignees

@tisma95 tisma95

Labels
need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

src/api/custom-elements.md
2 participants
@tisma95 @edimitchel