-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTK# / Xamarin.Forms.Gtk implementations (reloaded) #20
GTK# / Xamarin.Forms.Gtk implementations (reloaded) #20
Conversation
Well done! |
libvlcsharp/LibVLCSharp/Shared/Core.cs Line 157 in 1c0655b
|
This fails on GTK.Mac libvlcsharp/LibVLCSharp/Shared/Core.cs Line 132 in 1c0655b
No idea why, no logs... same libvlc gets loaded fine in the Xamarin.Mac Cocoa sample, and I got it working before... meh |
For your two remarks about mac, I just copy-pasted what you did, I didn't really understand. |
It was needed magic, unfortunately it does not work. https://github.com/dotnet/corefx/issues/19694 |
|
cc4ed45
to
8179532
Compare
Merged @mfkl 's suggestions into my branch and rebased / squashed the commits. @mfkl : What's left to do on your side with Mac? For linux, everything builds fine thanks to instructions here : mono/linux-packaging-msbuild#7, but I still can't build the Forms.Gtk.Sample :
It tells me it can't find |
LibVLCSharp.Forms.Platforms.GTK/LibVLCSharp.Forms.Platforms.GTK.csproj
Outdated
Show resolved
Hide resolved
Samples/Forms/LibVLCSharp.Forms.Sample.GTK/LibVLCSharp.Forms.Sample.GTK.csproj
Outdated
Show resolved
Hide resolved
The stackoverflow when the mouse cursor touches the GTK The rest is just annoying but we can ship without (CLI only, VS4Mac crashes when editing GTK projects). For linux, can you write a small instruction guide to get proper libvlc (for ubuntu at least) and whatever else is needed to get the sample running? Will add it to the gitlab wiki page. |
0f21261
to
f55b986
Compare
LibVLCSharp.Forms.Platforms.GTK/LibVLCSharp.Forms.Platforms.GTK.csproj
Outdated
Show resolved
Hide resolved
f55b986
to
e07ad19
Compare
I managed to make the Xamarin.Forms sample work on linux: I fixed the project reference path (linux is case-sensitive) and restored the packages with It works well, but it's quite manual. Shall we switch to a SDK-style project instead? Shall we make a template project? |
Sure. Are you saying that would help fix the manual restore part?
Not sure what you mean. Sample project? |
I guess: instead of
A repo project that can be used to |
This makes it easier to consume (`msbuild /t:Restore`, `msbuild`)
72b2add
to
e50ea98
Compare
Current status: Almost done. ✔️ Remaining:
|
I'd argue you should merge without macOS for now. |
That's the plan. |
Merged a927af5. Good job 👍 |
replaces #2
Due to the recent changes in the libvlcsharp, too many conflicts prevented the proper merge of #2.
This is a new, better implementation. It should fix cross-platform build issues, but it still needs to be confirmed. (My msbuild on my linux has been broken by an update : mono/linux-packaging-msbuild#8 )
Forms.GTK# also works! The initialization bug does not affect us anymore due to the fact that the media player is now given externally.
Checklist
/cc @mfkl @Ch4rg3r